Skip to content

Write-Object -NoEnumerate should not wrap sigular object - #5123

Closed
PetSerAl wants to merge 5 commits into
PowerShell:masterfrom
PetSerAl:fix-write-object-noenumerate-sigular-object
Closed

Write-Object -NoEnumerate should not wrap sigular object#5123
PetSerAl wants to merge 5 commits into
PowerShell:masterfrom
PetSerAl:fix-write-object-noenumerate-sigular-object

Conversation

@PetSerAl

@PetSerAl PetSerAl commented Oct 15, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fix #5122
I decide to make ValueFromRemainingArguments to always unwrap single argument, even if it is not collection. Otherwise it would be impossible to distinguish two cases:

Write-Object -NoEnumerate 1
Write-Object -NoEnumerate ( [System.Collections.Generic.List[object]]::new((,1)) )

@iSazonov

Ilya (iSazonov) commented Oct 15, 2017

Copy link
Copy Markdown
Collaborator

PetSerAl What is the last commit? Need rebase?

@PetSerAl

PetSerAl commented Oct 15, 2017

Copy link
Copy Markdown
Contributor Author

Ilya (@iSazonov) I am cherry pick first commit from #5109, to make sure that tests pass too, since my change is more strong then proposed here. I think it would be more consistent to unwrap any single parameter passed as ValueFromRemainingArguments, while #5109 propose to unwrap only collections.

@daxian-dbw Dongbo Wang (daxian-dbw) mentioned this pull request Oct 15, 2017
Merged
@iSazonov

Ilya (iSazonov) commented Oct 16, 2017

Copy link
Copy Markdown
Collaborator

PetSerAl Michael Klement (@mklement0) Please see latest comments in #5109 about the PR.

@PetSerAl PetSerAl closed this Oct 19, 2017
@iSazonov

Ilya (iSazonov) commented Oct 19, 2017 •
edited
Loading

Copy link
Copy Markdown
Collaborator

PetSerAl Please add comment why the Issue was closed.

@PetSerAl

PetSerAl commented Oct 26, 2017

Copy link
Copy Markdown
Contributor Author

Ilya (@iSazonov) Given this comment and that #5109 is now merged, I do not see how my changes in binder can be accepted. And I do not see other way to fix #5122, thus I see no value in keeping this PR open. I do not closing #5122 though. If someone know how to fix it, then them can submit their own PR instead of this one.

@mklement0 Michael Klement (mklement0) mentioned this pull request Nov 26, 2017
Closed
@PetSerAl
PetSerAl deleted the fix-write-object-noenumerate-sigular-object branch August 22, 2018 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BrucePay Bruce Payette (BrucePay) Awaiting requested review from BrucePay
@dantraMSFT Dan Travison (dantraMSFT) Awaiting requested review from dantraMSFT
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
@JamesWTruher James Truher (JamesWTruher) Awaiting requested review from JamesWTruher
@lzybkr Jason Shirk (lzybkr) Awaiting requested review from lzybkr
@PaulHigin Paul Higinbotham (PaulHigin) Awaiting requested review from PaulHigin
@vors sergei (vors) Awaiting requested review from vors

Assignees

@lzybkr Jason Shirk (lzybkr)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@PetSerAl @iSazonov @lzybkr @dlwyatt