add tests for get-command -ShowCommandInfo#4906
Merged
Merged
Conversation
adityapatwardhan
requested changes
Sep 25, 2017
Member
There was a problem hiding this comment.
I suggest the following, so that we will see what is not matched in the output.
It 'Get-Command -ShowCommandInfo property field test' {
$commandInfo = Get-Command Get-Date -ShowCommandInfo
$properties = ($commandInfo | Get-Member -MemberType NoteProperty)
$propertiesAsString = $properties.name | out-string
$propertiesAsString | Should MatchExactly 'CommandType'
$propertiesAsString | Should MatchExactly 'Definition'
$propertiesAsString | Should MatchExactly 'Module'
$propertiesAsString | Should MatchExactly 'ModuleName'
$propertiesAsString | Should MatchExactly 'Name'
$propertiesAsString | Should MatchExactly 'ParameterSets'
}
Member
There was a problem hiding this comment.
This should also be structured like the comment above.
Member
There was a problem hiding this comment.
This should also be structured like the comment above.
Member
There was a problem hiding this comment.
This should be BeExactly
Member
There was a problem hiding this comment.
This seems to be doing Get-Command Get-Date -ShowCommandInfo a lot. This should be done once in BeforeAll and then used everywhere.
b087348 to
f6f649d
Compare
Contributor
Author
|
@adityapatwardhan thanks, your comment is addressed |
JamesWTruher
suggested changes
Sep 26, 2017
Collaborator
There was a problem hiding this comment.
since you executed Get-Command Get-Date -ShowCommandInfo couldn't this just be:
$testcases = @{observed = $commandInfo.Name; testname = "Name"; result = "Get-Date"},
@{observed = $commandInfo.ModuleName; testname = "ModuleName"; result = "Microsoft.PowerShell.Utility"},
@{observed = $commandInfo.Module.Name; testname = "Module"; result = "Microsoft.PowerShell.Utility"},
@{observed = $commandInfo.CommandType; testname = "CommandType"; result = "Cmdlet"},
@{observed = $commandInfo.Definition.Count; testname = "Definition"; result = 1}
It "Get-Command -ShowCommand property test - <testname>" -testcase $testcases {
param ( $observed, $result, $testname )
$observed | Should beExactly $result
}I'm not sure you need to executed Get-Command over and over
f6f649d to
bb5b1ef
Compare
Contributor
Author
|
@JamesWTruher thanks jim, your comment is resolved |
bb5b1ef to
eee0ece
Compare
Member
|
@JamesWTruher Can you have another look? |
Member
|
@JamesWTruher ping.. |
JamesWTruher
approved these changes
Oct 2, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is to resolve #4163
added tests for get-command -ShowCommandInfo