Skip to content

Remove double spaces between words in resx files (#4740) - #4741

Merged
Ilya (iSazonov) merged 1 commit into
PowerShell:masterfrom
korygill:master
Sep 3, 2017
Merged

Remove double spaces between words in resx files (#4740)#4741
Ilya (iSazonov) merged 1 commit into
PowerShell:masterfrom
korygill:master

Conversation

@korygill

@korygill Kory Gill (korygill) commented Sep 2, 2017

Copy link
Copy Markdown
Contributor

Fix for issue #4740.

@msftclas

Microsoft Contribution License Agreements (msftclas) commented Sep 2, 2017

Copy link
Copy Markdown

Kory Gill (@korygill),
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

iSazonov
Ilya (iSazonov) approved these changes Sep 2, 2017
View reviewed changes

@iSazonov Ilya (iSazonov) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kory Gill (@korygill) Thanks for fixing the typos!

markekraus
Mark Kraus (markekraus) approved these changes Sep 2, 2017
View reviewed changes

@markekraus Mark Kraus (markekraus) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

SteveL-MSFT
Steve Lee (SteveL-MSFT) approved these changes Sep 2, 2017
View reviewed changes

@SteveL-MSFT Steve Lee (SteveL-MSFT) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markekraus

Mark Kraus (markekraus) commented Sep 2, 2017

Copy link
Copy Markdown
Contributor

Steve Lee (@SteveL-MSFT) Thinking about this further, couldn't some of these possibly be Bucket 2 or 3 breaking changes since they modify errors that some may be relying on?

@SteveL-MSFT

Steve Lee (SteveL-MSFT) commented Sep 3, 2017

Copy link
Copy Markdown
Member

Mark Kraus (@markekraus) users should not rely on parsing error messages as they can be localized. the error messages are meant for humans to read. automation should rely on things like the FullyQualifiedErrorId and Exception types.

@markekraus

Mark Kraus (markekraus) commented Sep 3, 2017

Copy link
Copy Markdown
Contributor

Steve Lee (@SteveL-MSFT) Thanks! I was pretty sure that would be the answer but wanted to verify.

@iSazonov

Ilya (iSazonov) commented Sep 3, 2017

Copy link
Copy Markdown
Collaborator

We even have examples of where we changed (removed and added) FullyQualifiedErrorId and Exception types - this was due to error correction or the addition of new features and was therefore not considered an invalid or destructive change.

@iSazonov Ilya (iSazonov) self-assigned this Sep 3, 2017
@iSazonov
Ilya (iSazonov) merged commit c14648e into PowerShell:master Sep 3, 2017
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
@korygill @iSazonov
Remove double spaces between words in resx files (PowerShell#4741)
6ad105b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SteveL-MSFT Steve Lee (SteveL-MSFT) SteveL-MSFT approved these changes
@iSazonov Ilya (iSazonov) iSazonov approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan
@dantraMSFT Dan Travison (dantraMSFT) Awaiting requested review from dantraMSFT
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
@JamesWTruher James Truher (JamesWTruher) Awaiting requested review from JamesWTruher
@PaulHigin Paul Higinbotham (PaulHigin) Awaiting requested review from PaulHigin
+1 more reviewer
@markekraus Mark Kraus (markekraus) markekraus approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@iSazonov Ilya (iSazonov)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@korygill @msftclas @markekraus @SteveL-MSFT @iSazonov