Clean up FullCLR related scripts/docs - #4580
Merged
Aditya Patwardhan (adityapatwardhan) merged 1 commit intoAug 16, 2017
Merged
Conversation
Dongbo Wang (daxian-dbw)
requested review from
Travis Plunk (TravisEz13),
Aditya Patwardhan (adityapatwardhan) and
Ilya (iSazonov)
August 15, 2017 23:07
Dongbo Wang (daxian-dbw)
requested review from
James Truher (JamesWTruher) and
Joey Aiello (joeyaiello)
as code owners
August 15, 2017 23:07
Dongbo Wang (daxian-dbw)
removed request for
James Truher (JamesWTruher) and
Joey Aiello (joeyaiello)
August 15, 2017 23:07
Aditya Patwardhan (adityapatwardhan)
approved these changes
Aug 15, 2017
Aditya Patwardhan (adityapatwardhan)
left a comment
Member
There was a problem hiding this comment.
LGTM with minor comment
| { | ||
| $Command += "Import-Module '$Pester'; " | ||
| } | ||
| $Command += "Import-Module '$Pester'; " |
There was a problem hiding this comment.
Do we need this, now that we have module autoloading?
Member
Author
There was a problem hiding this comment.
I think we should keep it as the -Pester parameter can be given a different path than the one in our module path.
Ilya (iSazonov)
approved these changes
Aug 16, 2017
Travis Plunk (TravisEz13)
approved these changes
Aug 16, 2017
Travis Plunk (TravisEz13)
left a comment
Member
There was a problem hiding this comment.
Doc changes look good
Thatgfsj (Thatgfsj)
pushed a commit
to Thatgfsj/PowerShell
that referenced
this pull request
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #4357
This PR includes following changes:
build.psm1AppVeyor.psm1test/fullclr/PowerShellGithubDev.Tests.ps1