Skip to content

Fix Tests from #4479 - #4512

Merged
Aditya Patwardhan (adityapatwardhan) merged 2 commits into
PowerShell:masterfrom
markekraus:WebCmdletTestFix
Aug 7, 2017
Merged

Fix Tests from #4479#4512
Aditya Patwardhan (adityapatwardhan) merged 2 commits into
PowerShell:masterfrom
markekraus:WebCmdletTestFix

Conversation

@markekraus

@markekraus Mark Kraus (markekraus) commented Aug 6, 2017

Copy link
Copy Markdown
Contributor

My Bad... the tests I had in #4479 were failing in the nightly. This fixes them and now they now pass and fail for the right reasons.

@msftclas

Microsoft Contribution License Agreements (msftclas) commented Aug 6, 2017

Copy link
Copy Markdown

Mark Kraus (@markekraus),
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Aug 7, 2017

Copy link
Copy Markdown
Member

Mark Kraus (@markekraus) Thanks for fixing the tests. Can you run 'Feature' tests to validate that all the required tests are executed.

The documentation for executing additional tests is at: https://github.com/PowerShell/PowerShell/blob/master/docs/testing-guidelines/testing-guidelines.md

Look for the section titled 'Requesting additional tests for a PR'

@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Aug 7, 2017

Copy link
Copy Markdown
Member

Mark Kraus (@markekraus) I have pushed an empty commit to execute the feature tests.

@markekraus

Mark Kraus (markekraus) commented Aug 7, 2017

Copy link
Copy Markdown
Contributor Author

Aditya Patwardhan (@adityapatwardhan) Thank you. I will make sure to do this in the future.

@markekraus

Mark Kraus (markekraus) commented Aug 7, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Aditya Patwardhan (@adityapatwardhan) The tests pass now.

The Travis CI failure appears to be unrelated.

@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Aug 7, 2017

Copy link
Copy Markdown
Member

Mark Kraus (@markekraus) Restarted the tests on Travis CI.

@markekraus

Mark Kraus (markekraus) commented Aug 7, 2017

Copy link
Copy Markdown
Contributor Author

Aditya Patwardhan (@adityapatwardhan) All Travis CI Tests passing now as well

@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Aug 7, 2017

Copy link
Copy Markdown
Member

Dongbo Wang (@daxian-dbw) Can you have a quick look? This fixes the daily build failure.

@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) merged commit e4060ab into PowerShell:master Aug 7, 2017
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Aug 7, 2017

Copy link
Copy Markdown
Member

Mark Kraus (@markekraus) Thanks for fixing the tests.

@markekraus Mark Kraus (markekraus) mentioned this pull request Aug 8, 2017
Merged
@markekraus
Mark Kraus (markekraus) deleted the WebCmdletTestFix branch August 25, 2017 00:12
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
@markekraus @adityapatwardhan
Fix Tests from PowerShell#4479 (PowerShell#4512)
1242b09 
* Fix Tests from PowerShell#4479

* [Feature]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw Dongbo Wang (daxian-dbw) daxian-dbw approved these changes

Assignees

@adityapatwardhan Aditya Patwardhan (adityapatwardhan)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@markekraus @msftclas @adityapatwardhan @daxian-dbw