Clean up '#if CORE' in ClrFacade.cs#4366
Merged
Merged
Conversation
daxian-dbw
reviewed
Jul 28, 2017
| Marshal.StructureToPtr<T>(structure, ptr, deleteOld); | ||
| #else | ||
| Marshal.StructureToPtr(structure, ptr, deleteOld); | ||
| #endif |
Member
There was a problem hiding this comment.
For instances like the above ones, we should make changes in the call sites of those methods to directly use the API available in .NET Core, so that we can completely remove those methods from ClrFacade.cs.
Member
There was a problem hiding this comment.
You can leave them out, and I will clean them up later.
Collaborator
Author
There was a problem hiding this comment.
😕 I don't understand this in depth so leave them to you.
daxian-dbw
approved these changes
Jul 28, 2017
This was referenced Jul 28, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #4357 and #3565.