Skip to content

PSReadline unusable on ServerCore container - #3937

Merged
Jason Shirk (lzybkr) merged 1 commit into
PowerShell:masterfrom
SteveL-MSFT:psreadline-servercore
Jun 5, 2017
Merged

PSReadline unusable on ServerCore container#3937
Jason Shirk (lzybkr) merged 1 commit into
PowerShell:masterfrom
SteveL-MSFT:psreadline-servercore

Conversation

@SteveL-MSFT

Copy link
Copy Markdown
Member

The GetCurrentConsoleFontEx() api is available, but fails with unspecified error code on ServerCore running in container. Using similar logic to NanoServer where the api is not available, don't make the error fatal. Ignore the error so PSReadline continues to work. Impact is if using ServerCore on non-English (double char wide) characters.

Fix #3927

…on ServerCore but fails running in container to allow PSReadline to continue
@lzybkr
Jason Shirk (lzybkr) merged commit 22a3a89 into PowerShell:master Jun 5, 2017
@SteveL-MSFT
Steve Lee (SteveL-MSFT) deleted the psreadline-servercore branch June 19, 2017 21:16
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
…l#3937)

The api is available on ServerCore but fails (returns false) running in container.
Silently ignoring the failure allows PSReadline to work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants