Skip to content

Remove BuildVersion from $PSVersionTable - #3877

Merged
sergei (vors) merged 3 commits into
PowerShell:masterfrom
iSazonov:remove-buildversion
Jun 1, 2017
Merged

Remove BuildVersion from $PSVersionTable#3877
sergei (vors) merged 3 commits into
PowerShell:masterfrom
iSazonov:remove-buildversion

Conversation

@iSazonov

@iSazonov Ilya (iSazonov) commented May 29, 2017

Copy link
Copy Markdown
Collaborator

Close #1415

Motivation

PowerShell Committee concluded to remove BuildVersion property from $PSVersionTable as unneeded - now we use new GitCommitId property.

Fix

Remove BuildVersion from PSVersionHashTable and PSVersionInfo types and replace BuildVersion with GitCommitId in codes.

@iSazonov Ilya (iSazonov) changed the title Remove BuildVersion from PSVersionInfo type Remove BuildVersion from $PSVersionTable May 29, 2017
@iSazonov

Copy link
Copy Markdown
Collaborator Author

CI AppVeyor is failed on Set-Content.Tests.ps1 tests - it seems it is not related to the PR changes 😕

@SteveL-MSFT Steve Lee (SteveL-MSFT) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vors
sergei (vors) merged commit 9c42d2d into PowerShell:master Jun 1, 2017
@iSazonov
Ilya (iSazonov) deleted the remove-buildversion branch June 2, 2017 03:01
@iSazonov Ilya (iSazonov) added the Documentation Needed in this repo Documentation is needed in this repo label Jun 17, 2017
@joeyaiello Joey Aiello (joeyaiello) removed Documentation Needed in this repo Documentation is needed in this repo labels Oct 15, 2018
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
* Remove BuildVersion from PSVersionInfo type

* Fix error messages

* Remove BuildVersion from tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants