Skip to content

Fix build version handling when creating SemanticVersion objects - #3793

Merged
Mike Richmond (mirichmo) merged 1 commit into
PowerShell:masterfrom
mklement0:fix-semver-from-ver-constructor
May 17, 2017
Merged

Fix build version handling when creating SemanticVersion objects#3793
Mike Richmond (mirichmo) merged 1 commit into
PowerShell:masterfrom
mklement0:fix-semver-from-ver-constructor

Conversation

@mklement0

@mklement0 Michael Klement (mklement0) commented May 16, 2017 •
edited by mirichmo
Loading

Copy link
Copy Markdown
Contributor

Fix #3786

The appropriate [SemanticVersion] constructor now accepts a [version] instance that has only major and minor components specified, in which case the patch component now defaults to 0.

@mklement0
Fix for PowerShell#3786
2a43102 
The appropriate [SemanticVersion] constructor now accepts a [version] instance that has only major and minor components specified, in which case the patch component now defaults to 0.
@msftclas

Microsoft Contribution License Agreements (msftclas) commented May 16, 2017

Copy link
Copy Markdown

@mklement0,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.

It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@msftclas

Microsoft Contribution License Agreements (msftclas) commented May 16, 2017

Copy link
Copy Markdown

Michael Klement (@mklement0), thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.

Thanks, Microsoft Pull Request Bot

SteveL-MSFT
Steve Lee (SteveL-MSFT) approved these changes May 16, 2017
View reviewed changes

@SteveL-MSFT Steve Lee (SteveL-MSFT) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mklement0

Michael Klement (mklement0) commented May 16, 2017

Copy link
Copy Markdown
Contributor Author

Steve Lee (@SteveL-MSFT) Thanks; could you please also close the associated issue, #3786?

@mklement0
Michael Klement (mklement0) deleted the fix-semver-from-ver-constructor branch May 16, 2017 21:08
@lzybkr

Jason Shirk (lzybkr) commented May 16, 2017

Copy link
Copy Markdown
Contributor

Did you mean to close this? It wasn't merged, and can't be merged now because the branch was deleted.

@mklement0
Michael Klement (mklement0) restored the fix-semver-from-ver-constructor branch May 16, 2017 23:06
@mklement0

Michael Klement (mklement0) commented May 16, 2017

Copy link
Copy Markdown
Contributor Author

Jason Shirk (@lzybkr) Sorry, my bad: I though it was already merged.

@msftclas

Microsoft Contribution License Agreements (msftclas) commented May 16, 2017

Copy link
Copy Markdown

Michael Klement (@mklement0),
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@mirichmo Mike Richmond (mirichmo) changed the title Fix for #3786 Fix build version handling when creating SemanticVersion objects May 17, 2017
@mirichmo

Mike Richmond (mirichmo) commented May 17, 2017

Copy link
Copy Markdown
Member

I updated the title and description to conform to our specs.

@mirichmo
Mike Richmond (mirichmo) merged commit 30b97a5 into PowerShell:master May 17, 2017
@mklement0
Michael Klement (mklement0) deleted the fix-semver-from-ver-constructor branch May 17, 2017 01:03
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
@mklement0 @mirichmo
Fix for PowerShell#3786 (PowerShell#3793)
d349290 
The appropriate [SemanticVersion] constructor now accepts a [version] instance that has only major and minor components specified, in which case the patch component now defaults to 0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SteveL-MSFT Steve Lee (SteveL-MSFT) SteveL-MSFT approved these changes

Assignees

@mirichmo Mike Richmond (mirichmo)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mklement0 @msftclas @lzybkr @mirichmo @SteveL-MSFT