Skip to content

Use IntPtr(-1) for INVALID_HANDLE_VALUE instead of IntPtr.Zero - #3544

Merged
Dongbo Wang (daxian-dbw) merged 1 commit into
PowerShell:masterfrom
0xfeeddeadbeef:master
Apr 14, 2017
Merged

Use IntPtr(-1) for INVALID_HANDLE_VALUE instead of IntPtr.Zero#3544
Dongbo Wang (daxian-dbw) merged 1 commit into
PowerShell:masterfrom
0xfeeddeadbeef:master

Conversation

@0xfeeddeadbeef

@0xfeeddeadbeef Giorgi Chakhidze (0xfeeddeadbeef) commented Apr 12, 2017

Copy link
Copy Markdown
Contributor
  • Fix incorrect handling of GetCurrentProcess() API return value in IsWow64() function (MainEntry.cpp)
  • Remove unused INVALID_HANDLE_VALUE field from ProcessNativeMethods class (Process.cs)

Fixes #3540

- Fix incorrect handling of GetCurrentProcess() API return value in
  IsWow64() function (MainEntry.cpp)
- Remove unused INVALID_HANDLE_VALUE field from ProcessNativeMethods
  class (Process.cs)

Fixes #3540

@SteveL-MSFT Steve Lee (SteveL-MSFT) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iSazonov

Copy link
Copy Markdown
Collaborator

LGTM.

Giorgi Chakhidze (@0xfeeddeadbeef) Thanks! We will be glad to see you again with new contributions.

@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit 47ec6b2 into PowerShell:master Apr 14, 2017
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
…Shell#3544)

- Fix incorrect handling of 'GetCurrentProcess()' API return value in 'IsWow64()' function (MainEntry.cpp)
- Remove unused INVALID_HANDLE_VALUE field from 'ProcessNativeMethods' class (Process.cs)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants