Skip to content

Fix use of registry in nightly tests causing failure on Linux - #3377

Merged
Dongbo Wang (daxian-dbw) merged 1 commit into
PowerShell:masterfrom
SteveL-MSFT:helpsystem
Mar 21, 2017
Merged

Fix use of registry in nightly tests causing failure on Linux#3377
Dongbo Wang (daxian-dbw) merged 1 commit into
PowerShell:masterfrom
SteveL-MSFT:helpsystem

Conversation

@SteveL-MSFT

Copy link
Copy Markdown
Member

It appears that Pester is causing PowerShell to reflect on the Win32.Registry type which causes a type initialization exception even if not being used on Linux. Changed usage of registry to psdrive to avoid this problem.

Addresses #3098

@daxian-dbw

Copy link
Copy Markdown
Member

This if((-not ($skipTest)) -and $IsWindows) block was introduced because our default-browser-discovery code, which was used in Get-Help -Online, doesn't work correctly on the Azure code-coverage VM (see PR #3051). After #3281, that code was repalced by calling into ShellExecuteEx. Although I never tried on the Azure code-coverage VM, I think the problem should be solved, and if that's the case, this if block can be removed completely.

@vors

Copy link
Copy Markdown
Collaborator

LGTM, I'm going to re-assign it to Dongbo. If he is right that we don't need this code, it would be better to remove it completely.

@vors
sergei (vors) requested review from Dongbo Wang (daxian-dbw) and removed request for sergei (vors) March 21, 2017 01:25
@SteveL-MSFT

Copy link
Copy Markdown
Member Author

Dongbo Wang (@daxian-dbw) since this is blocking nightly's from passing, we should make a call on this sooner than later. perhaps we should merge this to get it passing and separately see if the code is still needed for CC?

@daxian-dbw

Copy link
Copy Markdown
Member

Steve Lee (@SteveL-MSFT) that sounds reasonable. #3079 is tracking this issue.

@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit d59a71f into PowerShell:master Mar 21, 2017
@SteveL-MSFT
Steve Lee (SteveL-MSFT) deleted the helpsystem branch March 21, 2017 20:23
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants