Skip to content

fixed drifting of progress bar on Unix - #3289

Merged
Dongbo Wang (daxian-dbw) merged 1 commit into
PowerShell:masterfrom
SteveL-MSFT:progressbar
Mar 11, 2017
Merged

fixed drifting of progress bar on Unix#3289
Dongbo Wang (daxian-dbw) merged 1 commit into
PowerShell:masterfrom
SteveL-MSFT:progressbar

Conversation

@SteveL-MSFT

Copy link
Copy Markdown
Member

progress bar was incorrectly setting the original x position which causes the progress to slowly move to the right in certain cases

addresses #3202

need some suggestions on how to add a test for this

…uses the progress to slowly move to the right in certain cases

addresses PowerShell#3202

@lzybkr Jason Shirk (lzybkr) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure it's worth adding a test for this.

The code doesn't change frequently, and it's difficult to test.

@SteveL-MSFT

Copy link
Copy Markdown
Member Author

Jason Shirk (@lzybkr) it's also something easily noticed by people using PowerShell if it's not working :)

@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit 9c40d29 into PowerShell:master Mar 11, 2017
@SteveL-MSFT
Steve Lee (SteveL-MSFT) deleted the progressbar branch March 21, 2017 19:53
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
The progress bar was incorrectly setting the original x position which causes the progress to slowly move to the right in certain cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants