Corect xUnit heading and linting warnings#3272
Merged
Merged
Conversation
|
@KevinMarquette, |
Member
|
cc @PowerShell/area-documentation |
Member
|
FYI, the DSC resources have a test to verify all markdown have these issues fixed. (I'd recommend disabling some of the rules like line length) Here: https://github.com/PowerShell/DscResource.Tests/blob/dev/Meta.Tests.ps1#L533 |
Member
|
LGTM, changes are all lint issues and one minor fromatting due to lint issues. |
TravisEz13
approved these changes
Mar 7, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that the xUnit heading as rendered on GitHub was not displaying as a heading. I made some other whitespace adjustments to make my markdown linter happier while I was in there. It was looking for a return line around headings, lists, and code blocks.