Skip to content

Remove System.Array type data - #3231

Merged
Dongbo Wang (daxian-dbw) merged 6 commits into
PowerShell:masterfrom
PetSerAl:remove-system.array-type-data
Mar 1, 2017
Merged

Remove System.Array type data#3231
Dongbo Wang (daxian-dbw) merged 6 commits into
PowerShell:masterfrom
PetSerAl:remove-system.array-type-data

Conversation

@PetSerAl

@PetSerAl PetSerAl commented Feb 28, 2017

Copy link
Copy Markdown
Contributor

Closes #3222

@msftclas

Microsoft Contribution License Agreements (msftclas) commented Feb 28, 2017

Copy link
Copy Markdown

PetSerAl,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@daxian-dbw

Dongbo Wang (daxian-dbw) commented Feb 28, 2017

Copy link
Copy Markdown
Member

#3230 is opened to track other *.generated.cs files.

@daxian-dbw Dongbo Wang (daxian-dbw) mentioned this pull request Feb 28, 2017
Closed
iSazonov
Ilya (iSazonov) reviewed Feb 28, 2017
View reviewed changes
Comment thread test/powershell/Modules/Microsoft.PowerShell.Utility/typedata.tests.ps1 Outdated
Context "Get-TypeData" {
It "System.Array" {
(Get-TypeData System.Array).TypeName | Should Be System.Array
Get-TypeData System.Array | Should Be $null

@iSazonov Ilya (iSazonov) Feb 28, 2017

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this test? Maybe remove?

@PetSerAl PetSerAl Feb 28, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just add it by analogy to other existing test. If you think, that it is not necessary here, then I can remove that last commit.

@daxian-dbw Dongbo Wang (daxian-dbw) Mar 1, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this test using on-page edit.

@PetSerAl PetSerAl Mar 1, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dongbo Wang (@daxian-dbw) You could just remove one last commit.

@daxian-dbw Dongbo Wang (daxian-dbw) Mar 1, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PetSerAl Yes. I made this change with the online editor. But I'm going to squash and merge, so it should be fine.

@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit c490e36 into PowerShell:master Mar 1, 2017
@daxian-dbw

Dongbo Wang (daxian-dbw) commented Mar 1, 2017

Copy link
Copy Markdown
Member

PetSerAl Thanks for the contribution!

@SteveL-MSFT Steve Lee (SteveL-MSFT) mentioned this pull request Mar 16, 2017
Closed
@PetSerAl
PetSerAl deleted the remove-system.array-type-data branch March 19, 2017 00:02
This was referenced Nov 28, 2017
Closed
Open
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
@PetSerAl @daxian-dbw
Remove System.Array type data (PowerShell#3231)
fa6b8ef 
* Rename Types_Ps1Xml.generated.cs
* Remove <auto-generated> header from Types_Ps1Xml.cs
* Remove System.Array type data
* Update `Get-TypeData` tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw Dongbo Wang (daxian-dbw) daxian-dbw approved these changes
@iSazonov Ilya (iSazonov) iSazonov left review comments

Assignees

@daxian-dbw Dongbo Wang (daxian-dbw)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@PetSerAl @msftclas @daxian-dbw @iSazonov