Skip to content

Remove async tests for parser#3119

Merged
daxian-dbw merged 2 commits into
PowerShell:masterfrom
JamesWTruher:jameswtruher/AsyncParserTestRevert
Feb 16, 2017
Merged

Remove async tests for parser#3119
daxian-dbw merged 2 commits into
PowerShell:masterfrom
JamesWTruher:jameswtruher/AsyncParserTestRevert

Conversation

@JamesWTruher
Copy link
Copy Markdown
Collaborator

this is a fix for #3069
and removes an attempt to work-around the issue of tests hanging on Travis-CI.

The hanging tests in Travis-CI have now been seen in a number of places, getting a dump during this condition has been problematic.

@PowerShellTeam PowerShellTeam added the Review - Needed The PR is being reviewed label Feb 9, 2017
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the finally block below should also be removed?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@daxian-dbw
Copy link
Copy Markdown
Member

Test hang again in Linux CI. I restarted the CI.

@daxian-dbw daxian-dbw self-assigned this Feb 9, 2017
@daxian-dbw daxian-dbw added Review - Waiting on Author and removed Review - Needed The PR is being reviewed labels Feb 9, 2017
this is a fix for PowerShell#3069
This removes an attempt to work-around the issue of tests hanging on Travis-CI.
@JamesWTruher JamesWTruher force-pushed the jameswtruher/AsyncParserTestRevert branch from d77c542 to 754e00b Compare February 15, 2017 20:47
@daxian-dbw daxian-dbw merged commit d801b75 into PowerShell:master Feb 16, 2017
@JamesWTruher JamesWTruher deleted the jameswtruher/AsyncParserTestRevert branch May 11, 2022 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants