Remove async tests for parser#3119
Merged
daxian-dbw merged 2 commits intoFeb 16, 2017
Merged
Conversation
daxian-dbw
requested changes
Feb 9, 2017
Member
There was a problem hiding this comment.
I guess the finally block below should also be removed?
Member
|
Test hang again in Linux CI. I restarted the CI. |
this is a fix for PowerShell#3069 This removes an attempt to work-around the issue of tests hanging on Travis-CI.
d77c542 to
754e00b
Compare
daxian-dbw
approved these changes
Feb 15, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is a fix for #3069
and removes an attempt to work-around the issue of tests hanging on Travis-CI.
The hanging tests in Travis-CI have now been seen in a number of places, getting a dump during this condition has been problematic.