Repository navigation
Fix the regex in ConsoleHost.Tests.ps1 used to verify help content - #28308
Merged
Merged
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The help-output assertion update has no active review issues.
No open issues 🎉
What changed in this PR
This PR corrects the help-output assertion in the ConsoleHost tests so unrelated output no longer satisfies it.
Changes:
- Escapes regex metacharacters to match the literal help synopsis.
- Adds
-hto the expected synopsis alongside-Help,-?, and/?.
| File | Description |
|---|---|
test/powershell/Host/ConsoleHost.Tests.ps1 |
Corrects the regex used to validate output for help parameters. |
Review effort: Balanced
Aditya Patwardhan (adityapatwardhan)
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix the regex used in
ConsoleHost.Tests.ps1for validating help content.The original pattern is simply wrong. For example, "This is unrelated output" matches the original pattern: