Skip to content

Avoid duplicate intrinsic method suggestions in tab completion #28301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Rudransh Shekhar (rudy-07) wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Avoid duplicate intrinsic method suggestions in tab completion #28301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6962,7 +6962,8 @@ private static void CompleteExtensionMethods(WildcardPattern pattern, List<Compl
{
foreach (var member in s_extensionMethods)
{
if (pattern.IsMatch(member.Item1))
if (pattern.IsMatch(member.Item1)
&& !results.Any(r => r.ListItemText.Equals(member.Item1, StringComparison.OrdinalIgnoreCase)))
{
string completionText = addMethodParenthesis ? $"{member.Item1}(" : member.Item1;
results.Add(new CompletionResult(completionText, member.Item1, CompletionResultType.Method, member.Item2));
Expand Down
14 changes: 14 additions & 0 deletions test/powershell/Host/TabCompletion/BugFix.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,20 @@ Describe "Tab completion bug fix" -Tags "CI" {
}
}

It "Issue#24729 - Tab completion does not return duplicate intrinsic method when type-native method exists" {
$list = [System.Collections.Generic.List[object]]::new()

$cmd = '$list.For'
$result = TabExpansion2 -inputScript $cmd -cursorColumn $cmd.Length
$result.CompletionMatches | Should -HaveCount 1
$result.CompletionMatches[0].CompletionText | Should -BeExactly "ForEach("

$cmd = '$list.PSFor'
$result = TabExpansion2 -inputScript $cmd -cursorColumn $cmd.Length
$result.CompletionMatches | Should -HaveCount 1
$result.CompletionMatches[0].CompletionText | Should -BeExactly "PSForEach("
}

Context "Issue#3416 - 'Select-Object'" {
BeforeAll {
$DatetimeProperties = @((Get-Date).psobject.baseobject.psobject.properties) | Sort-Object -Property Name
Expand Down