Repository navigation
chore: update DefaultPrompt in FR - #28240
Open
EDM115 (EDM115) wants to merge 1 commit into
Open
EDM115 (EDM115) wants to merge 1 commit into
EDM115 (EDM115) wants to merge 1 commit into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The localized correction matches the base resource and introduces no unresolved issues.
No open issues 🎉
What changed in this PR
Corrects the French ConsoleHost default prompt to match other languages.
Changes:
- Replaces
SP>withPS>, preserving XML encoding.
| File | Description |
|---|---|
| src/Microsoft.PowerShell.ConsoleHost/resources/fr/ConsoleHostStrings.fr.resx | Corrects the French default prompt. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Change the DefaultPrompt in French from "SP" to PS".
PR Context
This always bugged me and I couldn't find out why. At first I thought it was because my install corrupted and this was a way to notify "hey, something's gone wrong". but clearly not, and the fact that I use oh-my-posh hid this for a long time.
Anyway I checked the other languages and they all use "PS" so surely this was a typo. Unless it's actually meant to say "Shell Puissant" or something, I think it can be corrected. Also I believe since PowerShell is a trademark it should be represented correctly.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright header