Repository navigation
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The narrow optimization preserves join behavior, and existing multiline tests cover the affected path.
0 open findings
What changed in this PR
Removes an intermediate array allocation when joining buffered multiline input in ConvertFrom-Json.
Changes:
- Passes the existing list directly to
String.Join, preserving record order and newline separators.
| File | Description |
|---|---|
| src/Microsoft.PowerShell.Commands.Utility/commands/utility/WebCmdlet/ConvertFromJsonCommand.cs | Removes ToArray() from the buffered-input join. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Avoid materializing the buffered JSON input list as an intermediate array before joining multiline input.
String.Joincan consume the existingList<string>directly, preserving record order and the newline separator while removing one O(N) reference-array allocation.Validation
Import-Module .\tools\ci.psm1 -Force; Start-PSBuild -NoPSModuleRestoreStart-PSPester -Path test/powershell/Modules/Microsoft.PowerShell.Utility/ConvertFrom-Json.Tests.ps1 -SkipTestToolBuild -ThrowOnFailure -Terse(84 passed)No behavior changes are intended; the existing multiline-object tests cover the join path.