Repository navigation
Move Store version metadata to localized descriptions - #28211
Open
Justin Chung (jshigetomi) wants to merge 1 commit into
Open
Justin Chung (jshigetomi) wants to merge 1 commit into
Justin Chung (jshigetomi) wants to merge 1 commit into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 67b8368d-0bd9-4751-a85c-075eb3b60d8b
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The localized placeholder placements match the updated publishing logic, with no unresolved blocking issues.
0 open findings
What changed in this PR
Moves PowerShell’s Store version metadata into localized product descriptions, keeping release notes focused on the changelog.
Changes:
- Relocates the version placeholder across all 14 localized listings.
- Updates publishing validation and replacement to target each placeholder’s corresponding field.
| File | Description |
|---|---|
.pipelines/templates/release-MSIX-Publish.yml |
Validates and replaces placeholders in their new fields. |
.pipelines/store/PDPs/PDP/zh-Hant/PDP.xml |
Moves Traditional Chinese version metadata into description. |
.pipelines/store/PDPs/PDP/zh-Hans/PDP.xml |
Moves Simplified Chinese version metadata into description. |
.pipelines/store/PDPs/PDP/tr/PDP.xml |
Moves Turkish version metadata into description. |
.pipelines/store/PDPs/PDP/ru/PDP.xml |
Moves Russian version metadata into description. |
.pipelines/store/PDPs/PDP/pt-BR/PDP.xml |
Moves Brazilian Portuguese version metadata into description. |
.pipelines/store/PDPs/PDP/pl/PDP.xml |
Moves Polish version metadata into description. |
.pipelines/store/PDPs/PDP/ko/PDP.xml |
Moves Korean version metadata into description. |
.pipelines/store/PDPs/PDP/ja/PDP.xml |
Moves Japanese version metadata into description. |
.pipelines/store/PDPs/PDP/it/PDP.xml |
Moves Italian version metadata into description. |
.pipelines/store/PDPs/PDP/fr/PDP.xml |
Moves French version metadata into description. |
.pipelines/store/PDPs/PDP/es/PDP.xml |
Moves Spanish version metadata into description. |
.pipelines/store/PDPs/PDP/en-US/PDP.xml |
Moves English version placeholder into description. |
.pipelines/store/PDPs/PDP/de/PDP.xml |
Moves German version metadata into description. |
.pipelines/store/PDPs/PDP/cs/PDP.xml |
Moves Czech version metadata into description. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
| <!-- _locComment_text="{MaxLength=1500} {Locked=___VERSION___}{Locked=___CHANGELOGLINK___} App Release Note" -->Version: ___VERSION___ | ||
|
|
||
| Changelog: ___CHANGELOGLINK___</ReleaseNotes> | ||
| <!-- _locComment_text="{MaxLength=1500} {Locked=___VERSION___}{Locked=___CHANGELOGLINK___} App Release Note" -->Changelog: ___CHANGELOGLINK___</ReleaseNotes> |
There was a problem hiding this comment.
Suggested change
| <!-- _locComment_text="{MaxLength=1500} {Locked=___VERSION___}{Locked=___CHANGELOGLINK___} App Release Note" -->Changelog: ___CHANGELOGLINK___</ReleaseNotes> | |
| <!-- _locComment_text="{MaxLength=1500} {Locked=___CHANGELOGLINK___} App Release Note" -->Changelog: ___CHANGELOGLINK___</ReleaseNotes> |
| </Keywords> | ||
| <Description _locID="App_Description"> | ||
| <!-- _locComment_text="{MaxLength=10000} {Locked=Windows} App Description" -->PowerShell is a task-based command-line shell and scripting language built on .NET. PowerShell helps system administrators and power-users rapidly automate task that manage operating systems (Linux, macOS, and Windows) and processes. | ||
| <!-- _locComment_text="{MaxLength=10000} {Locked=___VERSION___}{Locked=Windows} App Description" -->___VERSION___ |
There was a problem hiding this comment.
Suggested change
| <!-- _locComment_text="{MaxLength=10000} {Locked=___VERSION___}{Locked=Windows} App Description" -->___VERSION___ | |
| <!-- _locComment_text="{MaxLength=10000} {Locked=___VERSION___}{Locked=Windows} App Description" -->Version: ___VERSION___ |
| @@ -18,7 +18,9 @@ | |||
| <!-- _locComment_text="{MaxLength=30} App keyword 7" -->Scripting</Keyword> | |||
| </Keywords> | |||
| <Description _locID="App_Description"> | |||
There was a problem hiding this comment.
You only need to update the en-US/PDP.xml file. The rest will be handled by Localization Pipeline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Moves the Store version placeholder from release notes into the product description for all 14 localized PDP files. Updates the Store release stage so
___VERSION___is replaced inbaseListing.descriptionand___CHANGELOGLINK___is replaced inbaseListing.releaseNotes.PR Context
The Store metadata now presents the released PowerShell version in the product description while keeping release notes focused on the changelog. The release pipeline previously targeted both placeholders in release notes, so it also needs to update each placeholder in its corresponding Store listing field.
Validated by parsing all 14 PDP XML files and executing the updated Store listing variable script against generated Store JSON; all locale replacements passed.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright header