Repository navigation
Protect ForEach() property assignment on non-core types in Constrained Language Mode - #28207
Open
Justin Chung (jshigetomi) wants to merge 2 commits into
Open
Justin Chung (jshigetomi) wants to merge 2 commits into
Justin Chung (jshigetomi) wants to merge 2 commits into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Human security review remains necessary for enforcement and audit behavior, with an unresolved compatibility regression.
1 open finding
What changed in this PR
Strengthens Constrained Language enforcement for property assignments through PowerShell’s intrinsic ForEach method.
Changes:
- Rejects non-core property assignments while allowing audit-only execution with logging.
- Adds tests for rejected non-core setters and permitted core-type setters.
| File | Description |
|---|---|
| test/powershell/Modules/Microsoft.PowerShell.Security/ConstrainedLanguageRestriction.Tests.ps1 | Adds property-assignment restriction tests. |
| src/System.Management.Automation/engine/runtime/Operations/MiscOps.cs | Adds setter enforcement and audit logging. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
| var property = member as PSPropertyInfo; | ||
| if (languageMode == PSLanguageMode.ConstrainedLanguage | ||
| && numArgs != 0 | ||
| && !CoreTypes.Contains(basedCurrent.GetType())) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This pull request strengthens the security enforcement for property setting via the
ForEachengine intrinsic method in Constrained Language mode and adds corresponding tests to verify the behavior. The main change is to prevent property assignment on non-core types when PowerShell is running in Constrained Language mode, except when the system is only auditing (not enforcing) the policy.PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright header