-
Notifications
You must be signed in to change notification settings - Fork 8.4k
Stop altering the PATH env variable by honoring the PSHome path in CommandDiscovery
#27757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Dongbo Wang (daxian-dbw)
wants to merge
8
commits into
PowerShell:master
Choose a base branch
from
daxian-dbw:env-path
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+115
−72
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
c981321
Stop altering the PATH env variable but honor the PSHome path in Comm…
daxian-dbw 57ab3f0
Minor change
daxian-dbw 9da7c31
Skip duplicate path of $PSHOME
daxian-dbw 201b9ac
Address Copilot feedback
daxian-dbw c91cf83
Fix a Start-Process test
daxian-dbw dedfa78
Detect hosted PowerShell
daxian-dbw 0fc9ec5
Small update
daxian-dbw 09c0e34
Rename _psHome to _psExeHome to differentiate it from $PSHOME
daxian-dbw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For 1, I think it's correct now.
For 2,
_cachedLookupPathswill be invalidated and reconstructed when the PATH env var is changed, but we don't want to recalculate_psHomein that case.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For 2, the question is rather what if we search for
pshomethroughout the source code, there is more than one place where it is used according to the old pattern. I.e., I would expect thatpshomeshould be cached in Utils.DefaultPowerShellAppBase, taking into account regular, dotnet tool and hosted scenarios.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I renamed the
_psHomevariable to_psExeHometo differentiate it from the$PSHOMEconcept._psExeHomeis the directory that contains the pwsh executable, which is not necessarily under$PSHOME. For example, the built-in pwsh in the .NET SDK docker container image is located atC:\Program Files\powershellfor Windows Server Core, and$PSHOME\pwsh.exedoesn't exist.The only place I plan to update next is the
PwshExePathin PowerShellProcessInstance. The current code is incorrect. I plan to reuse what I have here in theCommandDiscovery, in a separate PR.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Perhaps the best thing that could be done is to have a common code for each scenario somewhere in Utils. (Actually, it was originally like that once.)