Remove Test-Bom and the boms JSON files#27726
Open
daxian-dbw wants to merge 2 commits into
Open
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the now-unused Test-Bom functionality (and its helper class/functions) from the packaging module, along with the large BOM JSON inventories, following the earlier removal of MSI packaging where Test-Bom was previously used.
Changes:
- Deleted
Test-Bom,BomRecord, andTest-IsProductFilefromtools/packaging/packaging.psm1. - Removed
Test-Bomfrom the module’s exported functions list intools/packaging/packaging.psd1. - Deleted the platform BOM JSON files under
tools/packaging/boms/.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tools/packaging/packaging.psm1 | Removes the unused BOM verification implementation and related helpers. |
| tools/packaging/packaging.psd1 | Stops exporting Test-Bom from the packaging module manifest. |
| tools/packaging/boms/windows.json | Deletes the unused Windows BOM inventory file. |
| tools/packaging/boms/mac.json | Deletes the unused macOS BOM inventory file. |
| tools/packaging/boms/linux.json | Deletes the unused Linux BOM inventory file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Test-Bomwas only used inNew-MSIPackage, which was removed in #27213 as we are not building MSI packages for v7.7 and onward.Test-Bomis no longer used anywhere in PowerShell repo, so removing it and its helpers, as well as the boms JSON files, in this PR.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright header