[release/v7.4.18] Separate NuGet publish into its own stage after pushing the git tag#27648
Open
SeeminglyScience wants to merge 1 commit into
Conversation
…owerShell#27611) Co-authored-by: Justin Chung <chungjustin@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Backports the release-pipeline refactor to ensure NuGet publishing happens in a dedicated stage that runs only after the git tag is pushed and the GitHub draft release is made public, improving release sequencing correctness on release/v7.4.18.
Changes:
- Split the combined GitHub+NuGet publish stage into
PublishGitHubReleaseand a newPublishNugetReleasestage that runs afterPushGitTagAndMakeDraftPublic. - Introduce a new
release-Nuget.ymltemplate containing the NuGet push job previously embedded in the GitHub release template. - Remove the NuGet publishing job from
release-github.ymlso it only handles the GitHub draft/release work.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.pipelines/templates/stages/PowerShell-Release-Stages.yml |
Splits GitHub vs NuGet publishing into separate stages and updates stage dependencies/order. |
.pipelines/templates/release-Nuget.yml |
Adds a dedicated NuGet publish job template, driven by skipPublish. |
.pipelines/templates/release-github.yml |
Removes NuGet publish job so the template only creates/manages the GitHub release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #27611 to release/v7.4.18
Triggered by @SeeminglyScience on behalf of @jshigetomi
Original CL Label: CL-BuildPackaging
/cc @PowerShell/powershell-maintainers
Impact
REQUIRED: Choose either Tooling Impact or Customer Impact (or both). At least one checkbox must be selected.
Tooling Impact
Separates NuGet publishing into its own dedicated pipeline stage that runs after the git tag is pushed and the GitHub release draft is made public. This ensures NuGet packages are only published after the release is official, improving release pipeline correctness and reliability.
Customer Impact
Regression
REQUIRED: Check exactly one box.
This is not a regression.
Testing
This is a pipeline-only change. The release pipeline stages and template references have been verified. Changes can only be fully validated by running the release pipeline. No unit tests apply to pipeline YAML changes.
Risk
REQUIRED: Check exactly one box.
Pipeline-only change that refactors release stages without modifying any product code. The change improves sequencing (NuGet publishes after git tag is pushed) and has no impact on the product binaries or runtime behavior.