WritePrintToken: replace WriteToConsole to avoid progress bar show during Read-Host AsSecureString#27643
Open
jserygit wants to merge 2 commits into
Open
Conversation
…er to avoid progress bar show during Read-Host AsSecureString
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
PR Context
When reading input with -AsSecureString, the console reads input one character at a time. After each key press, WritePrintToken() prints a "*" masking character, which eventually calls PostWrite(). Since PostWrite() shows the progress panel, the progress panel is repeatedly redisplayed while the user types.
This change replaces the direct call to WriteToConsole() with ConsoleOutWriteHelper(), matching the standard console output path. Additionally, when the interactive test tool is listening and console output is redirected, the masking character is written a second time to preserve the expected output behavior for tests.
As a result, secure input now follows the same output pipeline as other console writes while maintaining compatibility with the interactive test infrastructure.
Fix #26843
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright header