Simplify string concatenation#27569
Open
jnyrup wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR refactors VtSubstring string construction to avoid StringBuilder and instead build the final string via string.Concat using spans.
Changes:
- Replaced
StringBuilder-based concatenation with a singlestring.Concat(...)call. - Removed manual capacity calculation / preallocation.
| .Append(str, startOffset, length) | ||
| .Append(appendStr) | ||
| .ToString(); | ||
| return string.Concat(prependStr, str.AsSpan(startOffset, length), appendStr); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Simplify string concatenation
PR Context
I originally wanted to fix the missing parentheses in computing the capacity, as
+binds stronger than??, but noticed that the concatenation could be done easier withoutStringBuilderPowerShell/src/System.Management.Automation/utils/StringUtil.cs
Line 246 in c23c421
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright header