Fix PSVersionTable tag GitCommitId test#27523
Open
KirtiRamchandani wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Update
PSVersionTable.Tests.ps1so tag builds accept both validGitCommitIdforms:7.6.2git describe --longform, such as7.6.2-0-g<sha>PR Context
ProductVersionfor a tag build can includeSHA: <sha>even when the builtGitCommitIdis7.6.2-0-g<sha>. The previous test treated the-0-g<sha>form as unexpected wheneverProductVersiondid not includeCommits:, which makes the test fail for clean builds from a release tag.This keeps the exact check for normal commit builds, strips any
+<source revision>suffix from the product-version SHA before comparing, and adds regression coverage for the zero-commit tag case.Fixes #27503
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerTests
Start-PSBootstrap -Scenario DotnetStart-PSBuild -UseNuGetOrg -SkipExperimentalFeatureGenerationStart-PSPester -Path ./test/powershell/Host/PSVersionTable.Tests.ps1 -UseNuGetOrg -SkipTestToolBuild -ThrowOnFailure(16 passed)git diff --check