Refactor SetVariable method signatures to return PSVariable#27407
Open
xtqqczze wants to merge 1 commit into
Open
Refactor SetVariable method signatures to return PSVariable#27407xtqqczze wants to merge 1 commit into
xtqqczze wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors internal session-state variable setting APIs to return PSVariable directly (instead of object), improving type-safety and removing now-unnecessary casts at call sites.
Changes:
- Updated
SessionStateInternal.SetVariable(PSVariable, ...)and the underlyingSetVariable(VariablePath, ..., force, ...)overload to returnPSVariable. - Updated call sites to use the new
PSVariablereturn type without casting. - Removed dead/obsolete preprocessor-guarded code in the provider-path branch of
SetVariable(VariablePath, ...).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/System.Management.Automation/namespaces/VariableProvider.cs |
Consumes the new PSVariable return type directly (removes unnecessary as PSVariable cast). |
src/System.Management.Automation/engine/SessionStateVariableAPIs.cs |
Changes SetVariable overload return types to PSVariable and removes dead #if/#else code. |
src/System.Management.Automation/engine/MshCommandRuntime.cs |
Updates pipeline-variable setup to use PSVariable return type directly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.