Skip to content

Fix Start-Process -PassThru when no handle is returned #27301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tom Plant (pl4nty) wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix Start-Process -PassThru when no handle is returned #27301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b7bbae
Fix `Start-Process -PassThru` when no handle is returned
pl4nty Apr 19, 2026
e1576f9
Fix test throw detection and clean up afterwards
pl4nty Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/Microsoft.PowerShell.Commands.Management/commands/management/Process.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2649,10 +2649,14 @@ private ProcessInformation StartWithCreateProcess(ProcessStartInfo startinfo)
/// </summary>
private Process StartWithShellExecute(ProcessStartInfo startInfo)
{
Process result = null;
Process result = new() { StartInfo = startInfo };
try
{
result = Process.Start(startInfo);
if (!result.Start())
{
string msg = StringUtil.Format(ProcessResources.FailedToCreateProcessObject, startInfo.FileName);
WriteDebug(msg);
}
}
catch (Win32Exception ex)
{
Expand Down
5 changes: 5 additions & 0 deletions test/powershell/Modules/Microsoft.PowerShell.Management/Start-Process.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,11 @@ Describe "Start-Process" -Tag "Feature","RequireAdminOnWindows" {
$process | Stop-Process
}

It "Should start ms-settings URI with ShellExecute" -Skip:(!$isFullWin) {
{ Start-Process ms-settings: -PassThru } | Should -Not -Throw
Get-Process "SystemSettings" | Stop-Process
}

It "Should be able to use the -WhatIf switch without performing the actual action" {
$pingOutput = Join-Path $TestDrive "pingOutput.txt"
{ Start-Process -Wait $pingCommand -ArgumentList $pingParam -RedirectStandardOutput $pingOutput -WhatIf -ErrorAction Stop @extraArgs} | Should -Not -Throw
Expand Down