Change webcmdlets to default to https if a schema isn't specified for the uri#27238
Open
SteveL-MSFT wants to merge 2 commits intoPowerShell:masterfrom
Open
Change webcmdlets to default to https if a schema isn't specified for the uri#27238SteveL-MSFT wants to merge 2 commits intoPowerShell:masterfrom
SteveL-MSFT wants to merge 2 commits intoPowerShell:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the web cmdlet URI normalization logic so that scheme-less -Uri inputs are treated as HTTPS by default, aligning default behavior with secure transport expectations in Invoke-WebRequest/Invoke-RestMethod.
Changes:
- Changed
CheckProtocol()to prependhttps://(instead ofhttp://) when the providedUriis not absolute.
Contributor
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Change URI construction to default to https instead of http if a uri is specified without the scheme
PR Context
N/A
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright header