Fix duplicate ProductVersion SHA#27191
Open
badgerbees wants to merge 1 commit intoPowerShell:masterfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR prevents the .NET SDK from automatically appending the repository source revision to InformationalVersion, avoiding a duplicated commit SHA in the resulting PE file version metadata while preserving PowerShell’s existing git-derived version formatting.
Changes:
- Disables the .NET SDK “source revision suffix” behavior by setting
IncludeSourceRevisionInInformationalVersion=false. - Keeps
InformationalVersion/ProductVersionaligned with$(PSCoreFormattedVersion)produced by PowerShell’s existing git version logic.
Contributor
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR removes the duplicated commit SHA from
VersionInfo.ProductVersionin PowerShell PE files by disabling the .NET SDK's automatic source revision suffix.PR Context
PowerShell already formats
ProductVersionwith its own git-derived version string inPowerShell.Common.props. The .NET SDK was appendingSourceRevisionIda second time, which caused the PE version resource to show the SHA twice. This change keeps the existing PowerShell version formatting and prevents the extra suffix from being added.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright header