Skip to content

Update LTS and StableRelease settings in metadata #27006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daxian-dbw merged 1 commit into from
Mar 11, 2026
Merged

Update LTS and StableRelease settings in metadata #27006

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tools/metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,6 @@
"ReleaseTag": "v7.5.4",
"LTSReleaseTag" : ["v7.4.13"],
"NextReleaseTag": "v7.6.0-preview.6",
"LTSRelease": { "PublishToChannels": false, "Package": false },
"StableRelease": { "PublishToChannels": false, "Package": false }
"LTSRelease": { "PublishToChannels": false, "Package": true },
"StableRelease": { "PublishToChannels": true, "Package": true }
Copy link

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

StableRelease has two spaces before the object ("StableRelease": { ... }). Since this line is being modified, consider normalizing spacing to match the rest of the JSON for consistency (single space after :).

Suggested change
"StableRelease": { "PublishToChannels": true, "Package": true }
"StableRelease": { "PublishToChannels": true, "Package": true }

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The StableRelease.Package flag set to true here does not appear to be referenced anywhere in the repo (only StableRelease.PublishToChannels is used). If the intent is to control package creation for stable releases via metadata (as described in the PR), the pipeline logic likely needs to be updated to consume this property; otherwise this change is effectively a no-op for package creation.

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With StableRelease.PublishToChannels set to true, any release branch/tag that is also detected as Preview (release tag contains -) will cause channelSelection.yml to set both IsStable and IsPreview to true and then fail its mutual-exclusion check. If preview release branches are created from this commit, they will likely break until this flag is flipped back; consider whether this config should be scoped to a stable-only release branch, or whether channelSelection.yml should ignore the Stable flag when $isPreview is true.

Suggested change
"StableRelease": { "PublishToChannels": true, "Package": true }
"StableRelease": { "PublishToChannels": false, "Package": true }

Copilot uses AI. Check for mistakes.
}
Loading