Skip to content

[release/v7.5] Fix ConvertFrom-ClearlyDefinedCoordinates to handle API object coordinates #26987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adityapatwardhan merged 1 commit into from
Mar 10, 2026
Merged

[release/v7.5] Fix ConvertFrom-ClearlyDefinedCoordinates to handle API object coordinates #26987

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 19 additions & 8 deletions tools/clearlyDefined/src/ClearlyDefined/ClearlyDefined.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,19 +40,30 @@ function ConvertFrom-ClearlyDefinedCoordinates {
[CmdletBinding()]
param(
[parameter(mandatory = $true, ValueFromPipeline = $true)]
[string]
[object]
$Coordinates
)
Comment on lines 42 to 45
Copy link

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$Coordinates is now typed as [object], but the function no longer fails fast on $null (or unexpected object types). For example, $null input will take the else branch and return an object with all $null fields, which can later fail Start-ClearlyDefinedHarvest validation in a less obvious way. Consider adding ValidateNotNull() on the parameter and/or an explicit guard in Process that throws when $Coordinates is $null or does not contain the expected type/provider/namespace/name/revision fields (and similarly validate the split string has enough parts).

Copilot uses AI. Check for mistakes.

Begin {}
Process {
$parts = $Coordinates.Split('/')
[PSCustomObject]@{
type = $parts[0]
provider = $parts[1]
namespace = $parts[2]
name = $parts[3]
revision = $parts[4]
if ($Coordinates -is [string]) {
$parts = $Coordinates.Split('/')
[PSCustomObject]@{
type = $parts[0]
provider = $parts[1]
namespace = $parts[2]
name = $parts[3]
revision = $parts[4]
}
} else {
# Coordinates is already an object (e.g., from ClearlyDefined API response)
[PSCustomObject]@{
type = $Coordinates.type
provider = $Coordinates.provider
namespace = $Coordinates.namespace
name = $Coordinates.name
revision = $Coordinates.revision
}
}
}
End {}
Expand Down
Loading