Speed up Write-Host#2674
Merged
Merged
Conversation
An InformationRecord instance is created when calling Write-Host, but many of the properties aren't read. It can be expensive to initialize some of those properties, so the code has been changed to initialize those properties on first access.
30b2350 to
bbbc409
Compare
Contributor
Author
|
Assigning to @daxian-dbw to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Write-Host is creating an InformationRecord.
As part of the initialization of InformationRecord, we were initializing the ComputerName property.
This is apparently expensive, so I deferred initializing the value until the first time the property is accessed, which is uncommon, but will happen during remoting (because all properties are serialized).
In my local runs, CI tests ran much faster, 254s with the change, 305s without. A similar improvement is seen in calling Write-Host repeatedly - 2.2s for 4000 calls with the change, 47s without.