Skip to content

Remove unnecessary CS0618 suppressions from Variant APIs #26006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iSazonov merged 1 commit into from
Sep 7, 2025
Merged

Remove unnecessary CS0618 suppressions from Variant APIs #26006

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/Microsoft.PowerShell.ConsoleHost/WindowsTaskbarJumpList/PropVariant.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,7 @@ internal PropVariant(string value)
throw new ArgumentException("PropVariantNullString", nameof(value));
}

#pragma warning disable CS0618 // Type or member is obsolete (might get deprecated in future versions
_valueType = (ushort)VarEnum.VT_LPWSTR;
#pragma warning restore CS0618 // Type or member is obsolete (might get deprecated in future versions
_ptr = Marshal.StringToCoTaskMemUni(value);
}

Expand Down
3 changes: 0 additions & 3 deletions src/System.Management.Automation/engine/COM/ComInvoker.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,6 @@

using COM = System.Runtime.InteropServices.ComTypes;

// Disable obsolete warnings about VarEnum and COM-marshaling APIs in CoreCLR
#pragma warning disable 618

namespace System.Management.Automation
{
internal static class ComInvoker
Expand Down
5 changes: 0 additions & 5 deletions src/System.Management.Automation/engine/COM/ComUtil.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,9 +141,6 @@ private static string GetStringFromCustomType(COM.ITypeInfo typeinfo, IntPtr ref
return "UnknownCustomtype";
}

// Disable obsolete warning about VarEnum in CoreCLR
#pragma warning disable 618

/// <summary>
/// This function gets a string representation of the Type Descriptor
/// This is used in generating signature for Properties and Methods.
Expand Down Expand Up @@ -259,8 +256,6 @@ internal static Type GetTypeFromTypeDesc(COM.TYPEDESC typedesc)
return VarEnumSelector.GetTypeForVarEnum(vt);
}

#pragma warning restore 618

/// <summary>
/// Converts a FuncDesc out of GetFuncDesc into a MethodInformation.
/// </summary>
Expand Down
Loading