Enable SA1028: Code should not contain trailing whitespace#25959
Open
xtqqczze wants to merge 1 commit into
Open
Enable SA1028: Code should not contain trailing whitespace#25959xtqqczze wants to merge 1 commit into
SA1028: Code should not contain trailing whitespace#25959xtqqczze wants to merge 1 commit into
Conversation
iSazonov
approved these changes
Sep 3, 2025
Collaborator
|
/azp run PowerShell-Windows-Packaging-CI, PowerShell-CI-linux-packaging |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
TravisEz13
approved these changes
Sep 4, 2025
This was referenced Oct 15, 2025
513b58f to
5d136e0
Compare
Collaborator
|
/azp run PowerShell-Windows-Packaging-CI, PowerShell-CI-linux-packaging |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Collaborator
|
/azp run PowerShell-Windows-Packaging-CI, PowerShell-CI-linux-packaging |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Collaborator
|
@daxian-dbw Could you please approve/merge the style PR? |
Contributor
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
Contributor
There was a problem hiding this comment.
Pull request overview
Enables StyleCop analyzer rule SA1028 (no trailing whitespace) and updates existing C# sources to remove trailing whitespace so the rule can be enforced going forward.
Changes:
- Set
dotnet_diagnostic.SA1028.severitytowarningin.globalconfig. - Remove trailing whitespace (including whitespace-only blank lines) across touched C# files in engine, remoting, parser, help, and test tooling.
Reviewed changes
Copilot reviewed 1 out of 23 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/tools/WebListener/Controllers/CompressionController.cs | Removes trailing whitespace in controller actions. |
| test/tools/NamedPipeConnection/src/code/NamedPipeConnection.cs | Removes trailing whitespace in comments/blank lines. |
| src/System.Management.Automation/help/UpdateHelpCommand.cs | Removes trailing whitespace in cmdlet logic/comments. |
| src/System.Management.Automation/help/HelpNotFoundException.cs | Removes trailing whitespace in attributes/blank lines. |
| src/System.Management.Automation/help/HelpCommands.cs | Removes trailing whitespace in XML doc comment. |
| src/System.Management.Automation/help/HelpCategoryInvalidException.cs | Removes trailing whitespace and normalizes parameter line. |
| src/System.Management.Automation/engine/remoting/server/serverremotesession.cs | Removes trailing whitespace in DISCPowerShellConfiguration call. |
| src/System.Management.Automation/engine/remoting/fanin/WSManTransportManager.cs | Removes trailing whitespace in comment. |
| src/System.Management.Automation/engine/remoting/fanin/BaseTransportManager.cs | Removes whitespace-only blank line in enum. |
| src/System.Management.Automation/engine/remoting/common/RunspaceConnectionInfo.cs | Removes whitespace-only blank line in SSH process logic. |
| src/System.Management.Automation/engine/remoting/commands/SuspendJob.cs | Removes trailing whitespace in conditional. |
| src/System.Management.Automation/engine/remoting/commands/PushRunspaceCommand.cs | Removes trailing whitespace around overridden property braces. |
| src/System.Management.Automation/engine/remoting/commands/InvokeCommandCommand.cs | Removes trailing whitespace in accessors/comments. |
| src/System.Management.Automation/engine/remoting/client/ThrottlingJob.cs | Removes whitespace-only blank line. |
| src/System.Management.Automation/engine/remoting/client/Job2.cs | Removes trailing whitespace in Obsolete attribute line. |
| src/System.Management.Automation/engine/remoting/client/Job.cs | Removes trailing whitespace in Obsolete attribute line. |
| src/System.Management.Automation/engine/parser/TypeInferenceVisitor.cs | Removes whitespace-only blank lines within type inference visitors. |
| src/System.Management.Automation/engine/parser/ConstantValues.cs | Removes trailing whitespace in conditional. |
| src/System.Management.Automation/engine/MshCommandRuntime.cs | Removes whitespace-only blank line before comment block. |
| src/System.Management.Automation/engine/Modules/GetModuleCommand.cs | Removes whitespace-only blank line in Dispose. |
| src/System.Management.Automation/engine/hostifaces/PowerShellProcessInstance.cs | Removes whitespace-only blank line in Dispose. |
| src/System.Management.Automation/engine/hostifaces/Connection.cs | Removes whitespace-only blank line in property region. |
| .globalconfig | Enables SA1028 as a warning. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1028.md
Review with whitespace hidden