Skip to content

Fix infinite loop crash in variable type inference #25696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SeeminglyScience merged 1 commit into from
Jun 30, 2025
Merged

Fix infinite loop crash in variable type inference #25696

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/System.Management.Automation/engine/parser/Position.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,10 +338,7 @@ internal static bool IsAfter(this IScriptExtent extentToTest, IScriptExtent endE

internal static bool IsWithin(this IScriptExtent extentToTest, IScriptExtent extent)
{
return extentToTest.StartLineNumber >= extent.StartLineNumber &&
extentToTest.EndLineNumber <= extent.EndLineNumber &&
extentToTest.StartColumnNumber >= extent.StartColumnNumber &&
extentToTest.EndColumnNumber <= extent.EndColumnNumber;
return extentToTest.StartOffset >= extent.StartOffset && extentToTest.EndOffset <= extent.EndOffset;
}

internal static bool IsAfter(this IScriptExtent extent, int line, int column)
Expand Down
Loading