Skip to content

Update docs/scripts to use the alpha.11 release packages#2498

Merged
daxian-dbw merged 1 commit into
PowerShell:masterfrom
daxian-dbw:update-doc-on-release
Oct 18, 2016
Merged

Update docs/scripts to use the alpha.11 release packages#2498
daxian-dbw merged 1 commit into
PowerShell:masterfrom
daxian-dbw:update-doc-on-release

Conversation

@daxian-dbw

Copy link
Copy Markdown
Member

Update the docs and scripts to use the alpha.11 release packages.
/cc @andschwa @mirichmo @vors

@msftclas

Copy link
Copy Markdown

Hi @daxian-dbw, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Dongbo Wang). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

Comment thread docker/README.md Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the "g5ded651" portion of the filename consistent between releases?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andschwa, could you please comment?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah this text is just from a quoted example. It doesn't need to be changed (but being an example; there's really no harm in it changing either).

The original text alpha.10-310-g5ded651 came from having done a git describe on a commit that was not tagged (specifically commit g5ded651 which was 310 commits past alpha.10), which is what you're seeing here.

Comment thread docker/README.md Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto, just an example. I really don't know what would be the right thing to do here. Probably just ignore docker/README.md during programmatic updates (which we ought to script).

@andyleejordan andyleejordan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I double-checked, looks like you got them all.

@daxian-dbw daxian-dbw force-pushed the update-doc-on-release branch from 4ca5208 to 3abf95e Compare October 18, 2016 19:52
@daxian-dbw

Copy link
Copy Markdown
Member Author

Thanks @andschwa, I reverted the changes to docker/README.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants