Fix SA1411: Attribute constructor should not use unnecessary parenthesis - #24969
Open
xtqqczze wants to merge 1 commit into
Open
Fix SA1411: Attribute constructor should not use unnecessary parenthesis#24969xtqqczze wants to merge 1 commit into
SA1411: Attribute constructor should not use unnecessary parenthesis#24969xtqqczze wants to merge 1 commit into
Conversation
xtqqczze
requested a review
from Aditya Patwardhan (adityapatwardhan)
as a code owner
February 7, 2025 17:58
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
|
xtqqczze Could you please migrate our Settings.StyleCop rules to From https://github.com/DotNetAnalyzers/StyleCopAnalyzers
|
Ilya (iSazonov)
previously approved these changes
Feb 8, 2025
Ilya (iSazonov)
enabled auto-merge (squash)
February 8, 2025 06:26
Ilya (iSazonov)
disabled auto-merge
February 8, 2025 06:26
Ilya (iSazonov)
self-requested a review
February 8, 2025 06:27
Collaborator
|
Not all SA1411 fixed. |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Collaborator
As I said we should use .editorconfig. |
SA1411: Attribute constructor should not use unnecessary parenthesis
Contributor
Author
Changes to analyzer configuration should be in separate PR |
Ilya (iSazonov)
self-requested a review
February 25, 2025 16:10
Ilya (iSazonov)
previously approved these changes
Apr 23, 2025
Ilya (iSazonov)
self-requested a review
April 23, 2025 11:34
Collaborator
|
xtqqczze We need approving by code owners. |
Contributor
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
SA1411: Attribute constructor should not use unnecessary parenthesisSA1411: Attribute constructor should not use unnecessary parenthesis
Contributor
Author
|
Ilya (@iSazonov) removed changes requiring code owner approval |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1411.md
Contributes to #26922