Ensure the official build files CodeQL issues - #24278
Merged
Travis Plunk (TravisEz13) merged 10 commits intoSep 12, 2024
Merged
Conversation
Aditya Patwardhan (adityapatwardhan)
approved these changes
Sep 12, 2024
Travis Plunk (TravisEz13)
marked this pull request as ready for review
September 12, 2024 17:11
Travis Plunk (TravisEz13)
requested review from
Andrew (anmenaga) and
Dongbo Wang (daxian-dbw)
as code owners
September 12, 2024 17:11
Contributor
|
📣 Hey Travis Plunk (@TravisEz13), how did we do? We would love to hear your feedback with the link below! 🗣️ |
Thatgfsj (Thatgfsj)
pushed a commit
to Thatgfsj/PowerShell
that referenced
this pull request
Aug 6, 2026
* Enable and Disable CodeQL in the right places during the official build * fix codeql condition * fix syntax error * Enable codeQL issue filing * use parameter instead of branch to force codeql * try to name the build better * Update .pipelines/PowerShell-Coordinated_Packages-Official.yml * add debugging to display name of debugging parameters * fix spacing * Update .pipelines/PowerShell-Coordinated_Packages-Official.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This pull request includes several changes to enhance the configuration and pipeline scripts, primarily focusing on enabling CodeQL analysis conditionally based on the branch and improving the organization of the configuration files.
Configuration Enhancements:
codebaseNameto.config/tsaoptions.jsonto specify the name of the codebase. ([.config/tsaoptions.jsonR2](https://github.com/PowerShell/PowerShell/pull/24278/files#diff-5087085f56036da072ca64127f12fef07158982e2572f4e072dfce97bba799e2R2))Pipeline Script Improvements:
Conditional CodeQL Enablement:
CODEQL_ENABLEDin.pipelines/PowerShell-Coordinated_Packages-Official.ymlto conditionally enable CodeQL based on the branch. ([.pipelines/PowerShell-Coordinated_Packages-Official.ymlR77-R82](https://github.com/PowerShell/PowerShell/pull/24278/files#diff-b4a2090e3664c911fbfe10b93d8703cba9141cabb8707085b1b6885a4ee8653aR77-R82))codeqlsection in.pipelines/PowerShell-Coordinated_Packages-Official.ymlto use the newCODEQL_ENABLEDvariable. ([.pipelines/PowerShell-Coordinated_Packages-Official.ymlR100-R103](https://github.com/PowerShell/PowerShell/pull/24278/files#diff-b4a2090e3664c911fbfe10b93d8703cba9141cabb8707085b1b6885a4ee8653aR100-R103))Linux Pipeline Adjustments:
.pipelines/templates/linux.yml. ([.pipelines/templates/linux.ymlL36-R38](https://github.com/PowerShell/PowerShell/pull/24278/files#diff-d57c933d863854f9d912e16e721ee4f97370454f265d73be75d62448be712056L36-R38))CodeQL3000InitandCodeQL3000Finalizetasks to useCODEQL_ENABLEDvariable in.pipelines/templates/linux.yml. ([[1]](https://github.com/PowerShell/PowerShell/pull/24278/files#diff-d57c933d863854f9d912e16e721ee4f97370454f265d73be75d62448be712056L57-R64),[[2]](https://github.com/PowerShell/PowerShell/pull/24278/files#diff-d57c933d863854f9d912e16e721ee4f97370454f265d73be75d62448be712056L113-R115))Windows Pipeline Adjustments:
.pipelines/templates/windows-hosted-build.yml. ([.pipelines/templates/windows-hosted-build.ymlL37-R39](https://github.com/PowerShell/PowerShell/pull/24278/files#diff-75adb3400c53c5cbe183c86d9d543a4cda81cd7664b45c4bf3ce77478e8ff098L37-R39))CodeQL3000InitandCodeQL3000Finalizetasks to useCODEQL_ENABLEDvariable in.pipelines/templates/windows-hosted-build.yml. ([[1]](https://github.com/PowerShell/PowerShell/pull/24278/files#diff-75adb3400c53c5cbe183c86d9d543a4cda81cd7664b45c4bf3ce77478e8ff098L58-R65),[[2]](https://github.com/PowerShell/PowerShell/pull/24278/files#diff-75adb3400c53c5cbe183c86d9d543a4cda81cd7664b45c4bf3ce77478e8ff098L187-R189))PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.- [ ] Issue filed:
(which runs in a different PS Host).