Add macos signing for package files#24015
Merged
TravisEz13 merged 9 commits intoJul 11, 2024
Merged
Conversation
TravisEz13
reviewed
Jul 5, 2024
Comment on lines
+178
to
+183
| ConnectedServiceName: 'ESRPMacOSSigning' | ||
| AppRegistrationClientId: '9dfad4b0-b54d-463e-a4df-340b56fa720b' | ||
| AppRegistrationTenantId: '72f988bf-86f1-41af-91ab-2d7cd011db47' | ||
| AuthAKVName: 'pwsh-CICD-Keyvault' | ||
| AuthCertName: 'PS-macos-signing' | ||
| AuthSignCertName: 'ESRP-OneCert' # this is not needed for pkg signing |
TravisEz13
reviewed
Jul 5, 2024
| signConfigType: inlineSignParams | ||
| inlineOperation: | | ||
| [{ | ||
| "KeyCode": "CP-401337-Apple", |
TravisEz13
reviewed
Jul 5, 2024
| "ToolVersion": "1.0" | ||
| }] | ||
| SessionTimeout: 90 | ||
| ServiceEndpointUrl: 'https://api.esrp.microsoft.com/api/v2' |
Member
Author
|
@TravisEz13 - updated |
TravisEz13
approved these changes
Jul 11, 2024
Contributor
|
📣 Hey @adityapatwardhan, how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗 https://aka.ms/PSRepoFeedback |
adityapatwardhan
added a commit
that referenced
this pull request
Jul 15, 2024
* Sign macos packages * Fix typo * Add variables * Remove signing cert * Update signing * Add signing cert * Add uncompress * Add variable group * Download signed macos packages
adityapatwardhan
added a commit
that referenced
this pull request
Jul 15, 2024
* Sign macos packages * Fix typo * Add variables * Remove signing cert * Update signing * Add signing cert * Add uncompress * Add variable group * Download signed macos packages
adityapatwardhan
added a commit
that referenced
this pull request
Jul 16, 2024
adityapatwardhan
added a commit
that referenced
this pull request
Jul 16, 2024
chrisdent-de
pushed a commit
to chrisdent-de/PowerShell
that referenced
this pull request
Sep 12, 2024
* Sign macos packages * Fix typo * Add variables * Remove signing cert * Update signing * Add signing cert * Add uncompress * Add variable group * Download signed macos packages
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Add signing for macos package files
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.- [ ] Issue filed:
(which runs in a different PS Host).