Skip to content

Merge TFS 2064268: ConstrainedLanguage PowerShell should not block nested cmdlet invocation via runspace#2159

Merged
daxian-dbw merged 2 commits into
PowerShell:masterfrom
PaulHigin:GAMerge3
Sep 2, 2016
Merged

Merge TFS 2064268: ConstrainedLanguage PowerShell should not block nested cmdlet invocation via runspace#2159
daxian-dbw merged 2 commits into
PowerShell:masterfrom
PaulHigin:GAMerge3

Conversation

@PaulHigin
Copy link
Copy Markdown
Contributor

@PaulHigin PaulHigin commented Sep 1, 2016

Runspace creation in trusted script running under ConstrainedLanugage mode was failing with an unneeded security check. The security check occurred during the creation of the Question built-in variable and is unneeded because it is being created/set in a trusted context.

Fix is to create the built-in question variable at the same location and in the same way that other built-in variables are created.

@msftclas
Copy link
Copy Markdown

msftclas commented Sep 1, 2016

Hi @PaulHigin, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Paul Higinbotham). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@daxian-dbw daxian-dbw self-assigned this Sep 1, 2016
@daxian-dbw
Copy link
Copy Markdown
Member

daxian-dbw commented Sep 1, 2016

The AppVeyor CI failed and it seems related to your changes in SessionState.cs. Can you please fix it?
As for the Travis CI failure, we are work on resolving it.

@PaulHigin
Update SessionState.cs
7a9b34d 
Fixed ExecutionContext property name error.
@PaulHigin
Copy link
Copy Markdown
Contributor Author

PaulHigin commented Sep 1, 2016

Fixed ExecutionContext name error. Thanks.

@daxian-dbw
Copy link
Copy Markdown
Member

daxian-dbw commented Sep 1, 2016

LGTM. Waiting for the CI failure to be resolved.

@vors vors closed this Sep 2, 2016
@vors vors reopened this Sep 2, 2016
@msftclas
Copy link
Copy Markdown

msftclas commented Sep 2, 2016

Hi @PaulHigin, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Paul Higinbotham). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@daxian-dbw daxian-dbw merged commit fe1f035 into PowerShell:master Sep 2, 2016
@PaulHigin PaulHigin deleted the GAMerge3 branch September 14, 2016 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@daxian-dbw daxian-dbw

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@PaulHigin @msftclas @daxian-dbw @vors @TravisEz13