Fix rendering of DisplayRoot for network PSDrive#20793
Merged
Merged
Conversation
Collaborator
|
@SteveL-MSFT Now we remove the workaround with |
67b4fe1 to
69f69f0
Compare
iSazonov
reviewed
Nov 28, 2023
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
iSazonov
approved these changes
Nov 28, 2023
daxian-dbw
pushed a commit
that referenced
this pull request
Dec 7, 2023
daxian-dbw
added a commit
that referenced
this pull request
Dec 8, 2023
5 tasks
5 tasks
chrisdent-de
pushed a commit
to chrisdent-de/PowerShell
that referenced
this pull request
Sep 12, 2024
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
As part of some refactoring work to use spans, it appears that the code to get the DisplayRoot simply used
ToString()on the ushort buffer. However,ToString()only works on a span of chars, so this resulted in returning the type and size instead of the contents. Fix is to get a Unicode string from the ushort buffer as bytes.PR Context
Fix #19903
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).