Skip to content

Use HTTPS links for go.microsoft.com#2046

Merged
daxian-dbw merged 1 commit into
PowerShell:masterfrom
xiaoyinl:use-https-links
Sep 2, 2016
Merged

Use HTTPS links for go.microsoft.com#2046
daxian-dbw merged 1 commit into
PowerShell:masterfrom
xiaoyinl:use-https-links

Conversation

@xiaoyinl
Copy link
Copy Markdown
Contributor

For better security and privacy, I think it is better to use HTTPS links wherever possible. So I replace all occurrences of http://go.microsoft.com with https://go.microsoft.com in all non-binary files in this repository. Note that some go.microsoft.com links redirect to http and then to https, such as https://go.microsoft.com/fwlink/?LinkID=135255. They should redirect to https directly. Could you fix them on the server side?

@msftclas
Copy link
Copy Markdown

Hi @xiaoyinl, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

@vors
Copy link
Copy Markdown
Collaborator

vors commented Aug 24, 2016

I re-triggered Travis CI build, which was timed-out and may be unrelated to the change.

@daxian-dbw
Copy link
Copy Markdown
Member

LGTM. I think this shouldn't cause any issues to Update-Help or Get-Help -Online, but @Francisco-Gamino can you please confirm?

@Francisco-Gamino
Copy link
Copy Markdown
Contributor

We have get-help -online tests on Window which will break. However, I am not sure if these tests have been ported.

@adityapatwardhan, have we ported the get-help -online tests to GitHub? If we have not, then we need a work item to update fwlinks when porting these tests. Thanks.

@daxian-dbw
Copy link
Copy Markdown
Member

@Francisco-Gamino why get-help -online tests will break?

@adityapatwardhan
Copy link
Copy Markdown
Member

LGTM @JamesWTruher Are the help tests ported?

@Francisco-Gamino
Copy link
Copy Markdown
Contributor

LGTM. I opened an issue to port the updatable help tests to Open PowerShell. See #2164

@daxian-dbw daxian-dbw merged commit 58a2ba7 into PowerShell:master Sep 2, 2016
@xiaoyinl xiaoyinl deleted the use-https-links branch September 2, 2016 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants