Skip to content

Fix incorrect string to type conversion #19560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iSazonov merged 4 commits into from
May 31, 2023
Merged

Fix incorrect string to type conversion #19560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6ed619e
Fix incorrect string to type conversion
MartinGC94 Apr 24, 2023
1bca09c
Use extent, rather than the resolved typename in check.
MartinGC94 Apr 24, 2023
ff978ef
Apply suggestions from code review
MartinGC94 May 25, 2023
3edd6fc
Fix test
MartinGC94 May 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/System.Management.Automation/engine/parser/Parser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@ internal static ITypeName ScanType(string typename, bool ignoreErrors)
var result = parser.TypeNameRule(allowAssemblyQualifiedNames: true, firstTypeNameToken: out _);

SemanticChecks.CheckArrayTypeNameDepth(result, PositionUtilities.EmptyExtent, parser);
if (!ignoreErrors && parser.ErrorList.Count > 0)
if (!ignoreErrors && result is not null && (parser.ErrorList.Count > 0 || !result.Extent.Text.Equals(typename, StringComparison.OrdinalIgnoreCase)))
{
result = null;
}
Expand Down
8 changes: 8 additions & 0 deletions test/powershell/Language/Parser/Conversions.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,14 @@ Describe 'conversion syntax' -Tags "CI" {
$result -join ";" | Should -Be ($Elements -join ";")
}
}

It 'Should not convert invalid strings to type name using -as operator' {
'int]whatever' -as [type] | Should -Be $null
Comment thread
andyleejordan marked this conversation as resolved.
}
Comment thread
MartinGC94 marked this conversation as resolved.

It 'Should not convert invalid strings to type name using left-hand side operator' {
{[Type] 'int]whatever'} | Should -Throw
}
}

Describe "Type resolution should prefer assemblies in powershell assembly cache" -Tags "Feature" {
Expand Down