Skip to content

Add a finalize template which causes jobs with issues to fail #17314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TravisEz13 merged 7 commits into from
May 11, 2022
Merged

Add a finalize template which causes jobs with issues to fail #17314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a55cb9c
Add a finalize template
TravisEz13 May 11, 2022
20d9be7
add finalize to prep
TravisEz13 May 11, 2022
3683819
update display name
TravisEz13 May 11, 2022
230fca0
Add condition
TravisEz13 May 11, 2022
5b10f29
revert me: add fake issue
TravisEz13 May 11, 2022
2e63d37
fix display name
TravisEz13 May 11, 2022
6888a17
Revert "revert me: add fake issue"
TravisEz13 May 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tools/releaseBuild/azureDevOps/releaseBuild.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,3 +227,5 @@ stages:
Get-Content "$(Build.StagingDirectory)\release.json"
Write-Host "##vso[artifact.upload containerfolder=metadata;artifactname=metadata]$(Build.StagingDirectory)\release.json"
displayName: Create and upload release.json file to build artifact

- template: /tools/releaseBuild/azureDevOps/templates/step/finalize.yml
3 changes: 2 additions & 1 deletion tools/releaseBuild/azureDevOps/templates/checkAzureContainer.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ jobs:
UseJson: no

- task: AzurePowerShell@4
displayName: Check if blob exists and delete if specified
inputs:
azureSubscription: '$(AzureFileCopySubscription)'
scriptType: inlineScript
Expand All @@ -47,4 +48,4 @@ jobs:
}
}


- template: /tools/releaseBuild/azureDevOps/templates/step/finalize.yml
2 changes: 2 additions & 0 deletions tools/releaseBuild/azureDevOps/templates/compliance/compliance.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,3 +88,5 @@ jobs:
inputs:
sourceScanPath: '$(Build.SourcesDirectory)\tools'
snapshotForceEnabled: true

- template: /tools/releaseBuild/azureDevOps/templates/step/finalize.yml
2 changes: 2 additions & 0 deletions tools/releaseBuild/azureDevOps/templates/json.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,3 +53,5 @@ jobs:
inputs:
sourceScanPath: '$(Build.SourcesDirectory)\tools'
snapshotForceEnabled: true

- template: /tools/releaseBuild/azureDevOps/templates/step/finalize.yml
4 changes: 4 additions & 0 deletions tools/releaseBuild/azureDevOps/templates/linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,8 @@ jobs:
condition: and(succeeded(), ne(variables['SkipBuild'], 'true'))
workingDirectory: $(PowerShellRoot)

- template: /tools/releaseBuild/azureDevOps/templates/step/finalize.yml

- job: upload_${{ parameters.buildName }}
displayName: ${{ parameters.uploadDisplayName }} ${{ parameters.buildName }}
dependsOn: build_${{ parameters.buildName }}
Expand Down Expand Up @@ -335,3 +337,5 @@ jobs:
parameters:
artifactPath: '$(Build.StagingDirectory)\signedPackages\release'
condition: and(and(succeeded(), eq(variables['SHOULD_SIGN'], 'true')),eq(variables['buildName'], 'RPM'))

- template: /tools/releaseBuild/azureDevOps/templates/step/finalize.yml
2 changes: 2 additions & 0 deletions tools/releaseBuild/azureDevOps/templates/mac-file-signing.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,3 +118,5 @@ jobs:
inputs:
sourceScanPath: '$(repoRoot)\tools'
snapshotForceEnabled: true

- template: /tools/releaseBuild/azureDevOps/templates/step/finalize.yml
2 changes: 2 additions & 0 deletions tools/releaseBuild/azureDevOps/templates/mac-package-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,3 +133,5 @@ jobs:
inputs:
sourceScanPath: '$(PowerShellRoot)/tools'
snapshotForceEnabled: true

- template: /tools/releaseBuild/azureDevOps/templates/step/finalize.yml
2 changes: 2 additions & 0 deletions tools/releaseBuild/azureDevOps/templates/mac-package-signing.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,3 +130,5 @@ jobs:
inputs:
sourceScanPath: '$(repoRoot)/tools'
snapshotForceEnabled: true

- template: /tools/releaseBuild/azureDevOps/templates/step/finalize.yml
2 changes: 2 additions & 0 deletions tools/releaseBuild/azureDevOps/templates/mac.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,3 +59,5 @@ jobs:
inputs:
sourceScanPath: '$(Build.SourcesDirectory)/tools'
snapshotForceEnabled: true

- template: /tools/releaseBuild/azureDevOps/templates/step/finalize.yml
5 changes: 5 additions & 0 deletions tools/releaseBuild/azureDevOps/templates/step/finalize.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
steps:
- pwsh: |
throw "Jobs with an Issue will not work for release. Please fix the issue and try again."
displayName: Check for SucceededWithIssues
condition: eq(variables['Agent.JobStatus'],'SucceededWithIssues')
2 changes: 2 additions & 0 deletions tools/releaseBuild/azureDevOps/templates/testartifacts.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,3 +57,5 @@ jobs:
BuildTestPackage -runtime linux-musl-x64

displayName: Build test package and upload

- template: /tools/releaseBuild/azureDevOps/templates/step/finalize.yml
2 changes: 2 additions & 0 deletions tools/releaseBuild/azureDevOps/templates/windows-hosted-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,3 +78,5 @@ jobs:
inputs:
sourceScanPath: '$(PowerShellRoot)\tools'
snapshotForceEnabled: true

- template: /tools/releaseBuild/azureDevOps/templates/step/finalize.yml
2 changes: 2 additions & 0 deletions tools/releaseBuild/azureDevOps/templates/windows-package-signing.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,3 +134,5 @@ jobs:
inputs:
sourceScanPath: '$(repoRoot)\tools'
snapshotForceEnabled: true

- template: /tools/releaseBuild/azureDevOps/templates/step/finalize.yml
2 changes: 2 additions & 0 deletions tools/releaseBuild/azureDevOps/templates/windows-packaging.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,3 +353,5 @@ jobs:
}
displayName: Clean up local Clone
condition: always()

- template: /tools/releaseBuild/azureDevOps/templates/step/finalize.yml