Update prediction interface to provide additional feedback to a predictor plugin#15421
Merged
Conversation
rjmholt
reviewed
May 18, 2021
Member
Author
|
@rjmholt Thanks for your review! I've addressed your feedback, please take another look when you get a chance. |
22 tasks
iSazonov
reviewed
May 19, 2021
rjmholt
approved these changes
May 20, 2021
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Update prediction interface to provide additional feedback to a predictor plugin.
The changes are:
PredictionClientto represent a client. It provides additional information about the type of the client: terminal, editor.ICommandPredictorinterface to replace the propertiesSupportEarlyProcessingandAcceptFeedbackwith the methodCanAcceptFeedback(PredictionClient client, PredictorFeedbackKind feedback). So a predictor implementation can be specific about whether it accepts each feedback.OnCommandLineExecuted. It provides a predictor the information about the execution result (success or failure) of the last accepted user input.CommandPrediction, to minimize the allocation of the delegate helper object.PR Context
Az.Predictorteam asked for the new feedbackOnCommandExecuted, which provides the execution status (success or failure) of the last accepted user input.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.