Fix NullReferenceException in DSC ClearCache()#15373
Merged
Merged
Conversation
Member
|
Good catch, @anmenaga! Quoted from docs:
|
daxian-dbw
approved these changes
May 10, 2021
iSazonov
approved these changes
May 11, 2021
Author
|
This is needed for GC release in a couple of days, so merging. |
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
In a multi-threaded environment there is a NullReferenceException in DSC ClearCache().
This fix is needed for GuestConfig.
PR Context
Initial values for fields marked with ThreadStaticAttribute should not be used, because such initialization occurs only once, when the class constructor executes, and therefore affects only one thread. Sometimes in a multi-threaded GuestConfig environment this was causing NullReferenceException in
ClearCache()methods where the ThreadStatic filedt_currentImportDscResourceInvocationswas accessed.GuestConfig verified this fix on private binaries.
Side note: the entire section of code, where current fix is, will be removed soon by
DSC as a subsystemPR.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).