Avoid collecting logs in buffer if a pipeline execution event is not going to be logged#15350
Merged
Conversation
…going to be logged
iSazonov
reviewed
May 5, 2021
aungminko93750
approved these changes
May 5, 2021
iSazonov
reviewed
May 6, 2021
rjmholt
approved these changes
May 6, 2021
Collaborator
rjmholt
left a comment
There was a problem hiding this comment.
This change looks good to me. Having read through the discussions, I think the latest changes reflect the outcome of those discussions and agree with where the code stands now.
iSazonov
reviewed
May 7, 2021
iSazonov
approved these changes
May 7, 2021
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
A partial fix for #15341
The pipeline execution does a lot loggings. Today, we collect all the log strings in a buffer, and if the group policy
EnableModuleLoggingis enabled, strings from that buffer will be concatenated and used as the payload for writing out a pipeline execution-details event.The thing is, in most cases, the group policy
EnableModuleLoggingis NOT enabled, and we are just collecting a lot logging strings in a buffer list in vain. This PR makes changes to avoid collecting logs when we are not going to log the pipeline execution-details event.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.