Skip to content

Avoid LINQ in LanguagePrimitives.UpdateTypeConvertFromTypeTable#15168

Merged
anmenaga merged 1 commit into
PowerShell:masterfrom
xtqqczze:remove-linq2
May 17, 2021
Merged

Avoid LINQ in LanguagePrimitives.UpdateTypeConvertFromTypeTable#15168
anmenaga merged 1 commit into
PowerShell:masterfrom
xtqqczze:remove-linq2

Conversation

@xtqqczze
Copy link
Copy Markdown
Contributor

@xtqqczze xtqqczze commented Apr 6, 2021 •
edited
Loading

Avoid unnecessary allocations inside lock.

@ghost ghost assigned anmenaga Apr 6, 2021
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Apr 9, 2021
@xtqqczze xtqqczze closed this Apr 11, 2021
@xtqqczze xtqqczze reopened this Apr 11, 2021
@ghost ghost added the Stale label Apr 26, 2021
@ghost
Copy link
Copy Markdown

ghost commented Apr 26, 2021

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 10 days of this comment.

@xtqqczze xtqqczze changed the title WIP: Avoid allocation in LanguagePrimitives.UpdateTypeConvertFromTypeTable Avoid LINQ in LanguagePrimitives.UpdateTypeConvertFromTypeTable Apr 26, 2021
@ghost ghost removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept Stale labels Apr 26, 2021
@xtqqczze xtqqczze marked this pull request as ready for review April 26, 2021 20:44
@xtqqczze xtqqczze closed this Apr 26, 2021
@xtqqczze xtqqczze reopened this Apr 26, 2021
@ghost ghost added the Review - Needed The PR is being reviewed label May 4, 2021
@ghost
Copy link
Copy Markdown

ghost commented May 4, 2021

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

vexx32
vexx32 approved these changes May 4, 2021
View reviewed changes
Copy link
Copy Markdown
Collaborator

@vexx32 vexx32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, nicely done! 💖

@anmenaga anmenaga added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label May 5, 2021
@anmenaga
Copy link
Copy Markdown

anmenaga commented May 5, 2021

Restarted PowerShell-CI-macos.

@ghost ghost removed the Review - Needed The PR is being reviewed label May 5, 2021
@xtqqczze
Copy link
Copy Markdown
Contributor Author

xtqqczze commented May 8, 2021

@anmenaga PowerShell-CI-macos test failures are showing as new, could you try restarting again before I investigate further?

@anmenaga
Copy link
Copy Markdown

anmenaga commented May 14, 2021

Restarted PowerShell-CI-macos.

@xtqqczze xtqqczze closed this May 15, 2021
@xtqqczze xtqqczze reopened this May 15, 2021
@xtqqczze
Copy link
Copy Markdown
Contributor Author

xtqqczze commented May 15, 2021

@anmenaga tests have passed

@anmenaga anmenaga merged commit 5abb90f into PowerShell:master May 17, 2021
@xtqqczze xtqqczze deleted the remove-linq2 branch May 19, 2021 07:47
@ghost
Copy link
Copy Markdown

ghost commented May 27, 2021

🎉v7.2.0-preview.6 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@anmenaga anmenaga anmenaga approved these changes

@vexx32 vexx32 vexx32 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@anmenaga anmenaga

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xtqqczze @anmenaga @vexx32